Then I realized your mail comes in the same minute as my ping. Either you are reviewing super fast or we happen to be writing on this thread at the same time. Anyway, amazing.
--Max On Jul 21, 2014, at 19:16, Wang Weijun <[email protected]> wrote: > Oops, I didn't realized you've already reviewed it until I see see the whole > thread after the "ping again" mail. Must be because your mail does not have > name in either TO or CC. > > On Jul 21, 2014, at 19:12, Sean Mullan <[email protected]> wrote: > >> Why does the test have a 2009,2011 copyright? Otherwise, looks ok to me. > > I copied a test nearby and modified it into the new test. Will fix. > > Thanks > Max > > >> >> --Sean >> >> On 07/07/2014 10:12 PM, Wang Weijun wrote: >>> Please review the code change at >>> >>> http://cr.openjdk.java.net/~weijun/8048194/webrev.00 >>> >>> The original code goes on accepting the input mechToken even if it's of an >>> unsupported mech. It also mistakenly interprets the input token as a mech >>> token instead of a NegTokenTarg at the 2nd step. >>> >>> Thanks >>> Max >>> >
