Hi Chris,
updated webrev:
http://cr.openjdk.java.net/~xiaofeya/8181299/webrev.01/
-Felix
On 2017/6/1 17:11, Chris Hegarty wrote:
On 1 Jun 2017, at 04:27, Felix Yang <felix.y...@oracle.com> wrote:
Hi Chris and Daniel,
new webrev with a few of explicit builds than wildcard.
http://cr.openjdk.java.net/~xiaofeya/8181299/webrev.01/
This seems very odd to me:
http://cr.openjdk.java.net/~xiaofeya/8181299/webrev.01/test/sun/security/tools/jarsigner/AltProvider.java.sdiff.html
The test is using jdk.test.lib.util.JarUtils ( which comes from the
top-level test library ), but the @build specifies the JarUtils ( in
the unnamed package ) from the jdk test library.
Fixed
Also, shouldn’t it use jdk.test.lib.compiler.CompilerUtils, rather than
CompilerUtils?
Ok, refactored the test to use new CompilerUtils and then not referring
/lib/testlibrary any more.
I didn't touch other tests usage on CompilerUtils, because Igor has a
single purpose task to unify the test libs. It will complicate his
clean-up work.
-Felix
-Chris.