Your local workspace needs to be refreshed -- you are picking up an
older version of src/jdk.security.auth/share/classes/module-info.java
The module description after you apply your change should be:
* Provides implementations of the {@code javax.security.auth.*}
* interfaces and various authentication modules.
*
* @provides javax.security.auth.spi.LoginModule
Note the {@code} around the package name and the @provides which is not
in your webrev.
Otherwise looks fine, just make the change above -- no need to post
another update.
--Sean
On 6/19/17 9:17 AM, Weijun Wang wrote:
Updated at http://cr.openjdk.java.net/~weijun/8182118/webrev.02/.
--Max
On 06/19/2017 08:23 PM, Sean Mullan wrote:
On 6/19/17 8:17 AM, Weijun Wang wrote:
There is more than one, so this should be "implementations".
In fact, I originally used "implementations" (without "the") and "an
implementation", but then I saw the module-info.java for the module
saying "Contains the implementation of the javax.security.auth.*
interfaces" and thought "the implementation" is always correct.
I don't see where it uses the word "Contains".
I would probably just tweak that to say "Provides implementations of
the javax.security.auth.* interfaces and various authentication modules."
This would make the wording more consistent in the module and packages.
--Sean
