Looks fine to me. Mandy
> On Jun 19, 2017, at 6:17 AM, Weijun Wang <weijun.w...@oracle.com> wrote: > > Updated at http://cr.openjdk.java.net/~weijun/8182118/webrev.02/. > > --Max > > On 06/19/2017 08:23 PM, Sean Mullan wrote: >> On 6/19/17 8:17 AM, Weijun Wang wrote: >>>> There is more than one, so this should be "implementations". >>> >>> In fact, I originally used "implementations" (without "the") and "an >>> implementation", but then I saw the module-info.java for the module saying >>> "Contains the implementation of the javax.security.auth.* interfaces" and >>> thought "the implementation" is always correct. >> I don't see where it uses the word "Contains". >> I would probably just tweak that to say "Provides implementations of the >> javax.security.auth.* interfaces and various authentication modules." >> This would make the wording more consistent in the module and packages. >> --Sean
