Looks ok to me.
--Sean
On 12/4/19 9:49 PM, Weijun Wang wrote:
Ping the security side.
On Nov 26, 2019, at 12:36 AM, Erik Joelsson <erik.joels...@oracle.com> wrote:
Build change looks good.
/Erik
On 2019-11-22 18:59, Weijun Wang wrote:
Please review the change at
http://cr.openjdk.java.net/~weijun/8234697/webrev.00/
The new lines in Gensrc-java.base.gmk mimics the one for CLDR_GEN_DONE at the
beginning of the same file.
I changed the BigInteger parameter in the FieldParams constructor (the one not
reading terms) to its HEX string form and is now using the inverse. This makes
sure the strings appeared here are exactly the same as the one used in
CurveDB.java. The generated source code is identical to before.
Other smaller changes made to FieldGen.jsh:
1. Package name
2. No more jshell, but now Java
3. Input/output paths as args for main()
4. White spaces, wrapping and indentation
Thanks,
Max