On Wed, 7 Oct 2020 15:34:32 GMT, Lance Andersen <lan...@openjdk.org> wrote:
>> src/java.base/share/classes/java/util/jar/JarOutputStream.java line 97: >> >>> 95: * and re-compute its value automatically after the associted data >>> has been >>> 96: * completely deflated. >>> 97: * >> >> We probably need to do a bit wordsmithing here. >> >> I think I'd drop the first two sentences and instead start a new paragraph >> here (<p> tag) with "Unless explicitly set, >> the output stream will ignore ..." and see how that looks. >> Probably should be "the ZipEntry" rather than "a ZipEntry" to be consistent >> with the parameter description. > > Alan makes a good point. Perhaps we keep things simple and focus solely on > tweaking the description of the change in > behavior which is described in your last paragraph I totally agree. What about using just the last sentence (as you've proposed) in the spec section and add the other to as @implNote? O you think the last sentence will be enough? ------------- PR: https://git.openjdk.java.net/jdk/pull/520
