On Mon, 12 Oct 2020 18:26:14 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Xuelei comments > > src/java.base/share/classes/com/sun/crypto/provider/GCTR.java line 165: > >> 163: } >> 164: >> 165: int update(ByteBuffer src, ByteBuffer dst) { > > Based on the impl in GaloisCounterMode, this is only called when > src.remaining() >= 128. Perhaps documenting the conditions here as there are > no checks on the src/dst sizes as in the byte[] case. Sounds good ------------- PR: https://git.openjdk.java.net/jdk/pull/411