On Tue, 3 Nov 2020 00:15:37 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Anthony Scarpino has updated the pull request incrementally with six
>> additional commits since the last revision:
>>
>> - style
>> - style & comments
>> - full update
>> - remove old
>> - update
>> - outputsize
>
> src/java.base/share/classes/com/sun/crypto/provider/GCTR.java line 153:
>
>> 151: while (processed > MAX_LEN) {
>> 152: encrypt(in, offset, MAX_LEN, out, 0);
>> 153: dst.get(out, 0, MAX_LEN);
>
> Shouldn't this be "put" instead of "get"?
Yeah.. I'm surprised that wasn't caught by the tests. I will look to see what
case I need to make to check that.
> src/java.base/share/classes/com/sun/crypto/provider/GHASH.java line 211:
>
>> 209: }
>> 210:
>> 211: inLen -= (inLen % AES_BLOCK_SIZE);
>
> Maybe the if-(inLen == 0) check should be moved down after this line to cover
> cases where inLen < AES_BLOCK_SIZE?
Sure that makes sense.
-------------
PR: https://git.openjdk.java.net/jdk/pull/411
