On Thu, 29 Oct 2020 02:16:15 GMT, Hai-May Chao <hc...@openjdk.org> wrote:
>> Could someone please help review this PKCS#11 v3.0 header files update? >> >> Changes are straight-forward as below: >> 1) Updated pkcs11.h, pkcs11f.h, pkcs11t.h to v3.0 >> 2) Updated java side w/ the new constants definitions and name/error code >> mappings. >> >> For the native headers, it's a direct copy of the official v3.0 headers >> except that I have to remove the tab space, and trailing white spaces due to >> JDK code requirement. I verified the result using 'diff -w'. As for the java >> side, the edit is based on the diff of native headers. I also commented out >> some of the unused native identifiers at java side. >> >> I am adding the SHA-3 digests, signatures, and macs in a separate RFE and >> would need this one to be reviewed/integrated first. >> >> Thanks, >> Valerie > > src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11Constants.java > line 987: > >> 985: public static final long CKM_SP800_108_FEEDBACK_KDF = >> 0x000003adL; >> 986: public static final long CKM_SP800_108_DOUBLE_PIPELINE_KDF = >> 0x000003aeL; >> 987: > > Same comment. These three are just by themselves, so unless you feel strongly about, I prefer just leave them here which matches the ordering of pkcs11t.h, i.e. right before the CKM_VENDOR_DEFINED line. ------------- PR: https://git.openjdk.java.net/jdk/pull/917
