On Fri, 30 Oct 2020 21:44:00 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11Constants.java >> line 987: >> >>> 985: public static final long CKM_SP800_108_FEEDBACK_KDF = >>> 0x000003adL; >>> 986: public static final long CKM_SP800_108_DOUBLE_PIPELINE_KDF = >>> 0x000003aeL; >>> 987: >> >> Same comment. > > These three are just by themselves, so unless you feel strongly about, I > prefer just leave them here which matches the ordering of pkcs11t.h, i.e. > right before the CKM_VENDOR_DEFINED line. Just thought they could be moved like CKM_ECDSA_SHA3_224 to CKM_EDDSA (which are not matching to the ordering of pkcs11t.h), so we keep the ordering in PKCS11Constants. It's fine if you'd prefer as is. ------------- PR: https://git.openjdk.java.net/jdk/pull/917
