On Wed, 24 Mar 2021 03:25:02 GMT, Ziyi Luo <luoz...@openjdk.org> wrote:
>> This is a P2 regression introduced by JDK-8254717.
>>
>> In `RSAKeyFactory.engineGetKeySpec`, when the key is a RSA key and the
>> KeySpec is RSAPrivateKeySpec or RSAPrivateCrtKeySpec. The method behavior is
>> described as follow:
>>
>> X-axis: type of `keySpec`
>> Y-axis: type of `key`
>>
>> Before JDK-8254717:
>>
>> | | RSAPrivateKeySpec.class | RSAPrivateCrtKeySpec.class |
>> |--|--|--|
>> | RSAPrivateKey | Return RSAPrivateKeySpec | Throw
>> `InvalidKeySpecException` |
>> | RSAPrivateCrtKey | Return RSAPrivateKeySpec | Return RSAPrivateKeyCrtSpec |
>>
>> After JDK-8254717 (Green check is what we want to fix, red cross is the
>> regression):
>>
>> | | RSAPrivateKeySpec.class | RSAPrivateCrtKeySpec.class |
>> |--|--|--|
>> | RSAPrivateKey | Throw `InvalidKeySpecException` ❌ | Throw
>> `InvalidKeySpecException` |
>> | RSAPrivateCrtKey | Return RSAPrivateKeyCrtSpec ✅ | Return
>> RSAPrivateKeyCrtSpec |
>>
>> This commit fixes the regression.
>>
>>
>> ### Tests
>>
>> * Jtreg: All tests under `java/security`, `sun/security`, `javax/crypto`
>> passed
>> * JCK: All JCK-16 (I do not have jCK-17)tests under `api/java_security`
>> passed
>
> Ziyi Luo has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Remove trailing whitespace
> - Refactor P11RSAKeyFactory and improve tests
test/jdk/sun/security/pkcs11/rsa/TestP11KeyFactoryGetRSAKeySpec.java line 91:
> 89: if (testingSensitiveKeys) {
> 90: // Expected exception so swallow it
> 91: ex.printStackTrace();
Add a System.out.println() to clarify that this exception stack trace is
expected?
-------------
PR: https://git.openjdk.java.net/jdk/pull/2949
