On Tue, 30 Mar 2021 15:31:22 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update XMLUtils (not used by tests here)
>
> src/java.xml.crypto/share/classes/javax/xml/crypto/dsig/spec/RSAPSSParameterSpec.java
> line 99:
>
>> 97: * @return the encapsulated {@code PSSParameterSpec} object
>> 98: */
>> 99: public PSSParameterSpec getPSSParameterSpec() {
>
> If an XML Signature contained an RSAPSSParams with no DigestMethod, would
> this return a PSSParameterSpec with the defaults as specified in the
> @implSpec?
Yes. The `DOMRSAPSSSignatureMethod::unmarshalParams` method will fill the
blanks.
> src/java.xml.crypto/share/classes/javax/xml/crypto/dsig/spec/RSAPSSParameterSpec.java
> line 103:
>
>> 101: }
>> 102:
>> 103: @Override
>
> Since you are overriding `Object.hashCode` and `equals`, I think you should
> document the specification for that.
OK.
> src/java.xml.crypto/share/classes/javax/xml/crypto/dsig/spec/RSAPSSParameterSpec.java
> line 113:
>
>> 111:
>> 112: @Override
>> 113: public boolean equals(Object obj) {
>
> Add specification.
OK.
> src/java.xml.crypto/share/classes/javax/xml/crypto/dsig/spec/RSAPSSParameterSpec.java
> line 139:
>
>> 137:
>> 138: @Override
>> 139: public String toString() {
>
> Add specification.
OK.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3181
