On Wed, 14 Apr 2021 17:37:00 GMT, Sibabrata Sahoo <ssa...@openjdk.org> wrote:

>> This is a simple Test to add few additional API coverage for all java 
>> supported key types. The objective of this Test is to cover equals() and 
>> hashcode() methods for each key types.
>
> Sibabrata Sahoo has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Comment changed.
>   
>   Comment changed.

test/jdk/javax/crypto/KeyGenerator/CompareKeys.java line 124:

> 122:         public SecretKey genSecretKey() throws Exception {
> 123:             KeyGenerator kg = KeyGenerator.getInstance(this.algoName);
> 124:             return kg.generateKey();

Would be informative to print out which provider is tested, i.e. where this kg 
is from. Same goes for KeyPairGenerator.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3490

Reply via email to