On Thu, 15 Apr 2021 18:23:09 GMT, Valerie Peng <[email protected]> wrote:
>> Sibabrata Sahoo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Comment changed.
>>
>> Comment changed.
>
> test/jdk/javax/crypto/KeyGenerator/CompareKeys.java line 114:
>
>> 112: HmacSHA384("HmacSHA384"),
>> 113: HmacSHA512("HmacSHA512"),
>> 114: RC2("RC2");
>
> Just curious, how are these decided? Should this be an exhaustive list or
> just enough sampling for code coverage? If this is meant to be a general
> test, have you tried to not hardcoding the algorithm names to be enum?
> Otherwise, new algorithms will not be tested if not updating this test.
Done. Key(pair)Generator list will be collected dynamically. In fact it will
now test even the same algorithm names supported by different providers too
instead finding the 1st one.
> test/jdk/javax/crypto/KeyGenerator/CompareKeys.java line 124:
>
>> 122: public SecretKey genSecretKey() throws Exception {
>> 123: KeyGenerator kg = KeyGenerator.getInstance(this.algoName);
>> 124: return kg.generateKey();
>
> Would be informative to print out which provider is tested, i.e. where this
> kg is from. Same goes for KeyPairGenerator.
Added print statement for KeyGenerator and corresponding Provider list.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3490
