On Thu, 3 Jun 2021 16:04:19 GMT, Anthony Scarpino <ascarp...@openjdk.org> wrote:
>> Hi, >> >> I need a review of this rather large change to GCM. GCM will no longer use >> CipherCore, and AESCrypt to handle it's buffers and other objects. It is >> also a major code redesign limits the amount of data copies and make some >> performance-based decisions. >> >> Thanks >> >> Tony > > Anthony Scarpino has updated the pull request incrementally with three > additional commits since the last revision: > > - missed resultLen and undo decrypt heap hasarray check > - code review comments > - fix src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line 84: > 82: private static final int MAX_BUF_SIZE = Integer.MAX_VALUE; > 83: // data size when buffer is divided up to aid in intrinsics > 84: private static final int TRIGGERLEN = 4096; // 64k nit: comment should be 4k? ------------- PR: https://git.openjdk.java.net/jdk/pull/4072
