On Thu, 3 Jun 2021 16:04:19 GMT, Anthony Scarpino <ascarp...@openjdk.org> wrote:
>> Hi,
>>
>> I need a review of this rather large change to GCM. GCM will no longer use
>> CipherCore, and AESCrypt to handle it's buffers and other objects. It is
>> also a major code redesign limits the amount of data copies and make some
>> performance-based decisions.
>>
>> Thanks
>>
>> Tony
>
> Anthony Scarpino has updated the pull request incrementally with three
> additional commits since the last revision:
>
> - missed resultLen and undo decrypt heap hasarray check
> - code review comments
> - fix
src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java line
776:
> 774: if (dst != null) {
> 775: dst.put(block, 0, len);
> 776: }
Can this be "resultLen += op.doFinal(block, 0, len, dst)"?
-------------
PR: https://git.openjdk.java.net/jdk/pull/4072
