On Tue, 15 Feb 2022 19:51:57 GMT, Weijun Wang <[email protected]> wrote:
>> The enhancement adds two extra items in the `getSubjectAlternativeNames()`
>> output for an OtherName.
>>
>> It also fix several errors:
>> 1. In `OtherName.java`, `nameValue` should be the value inside `CONTEXT [0]`
>> without the tag and length bytes.
>> 2. The argument in constructor `extClass.getConstructor(Object.class)` is
>> suspicious. Maybe it meant `byte[]`.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> retell the formats
src/java.base/share/classes/java/security/cert/X509Certificate.java line 595:
> 593: * returned as byte arrays containing the ASN.1 DER encoded form of
> the
> 594: * name. There may be a third entry in the list for their {@code
> type-id}
> 595: * in string form, and a fourth entry for their {@code value} as
> either
I think "its" is more grammatically correct than "their".
src/java.base/share/classes/java/security/cert/X509Certificate.java line 597:
> 595: * in string form, and a fourth entry for their {@code value} as
> either
> 596: * a string (if the value is a valid supported character string)
> 597: * or (otherwise) a byte array containing the ASN.1 DER encoded from
> of
I don't think you need "(otherwise)" - it is redundant since you already say
"either ... or".
-------------
PR: https://git.openjdk.java.net/jdk/pull/7167
