On Thu, 28 Apr 2022 19:17:08 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update for getParameters() > > src/java.base/share/classes/javax/crypto/Cipher.java line 1056: > >> 1054: * parameters were not supplied and the underlying cipher >> implementation >> 1055: * can generate the parameter values, it will be returned. >> Otherwise, >> 1056: * {@code null} returned. > > Should this be "null is returned"? Yes, will fix. > src/java.base/share/classes/javax/crypto/Cipher.java line 1787: > >> 1785: * Ensures that Cipher is in a valid state for update() and >> doFinal() >> 1786: * calls - should be initialized and in ENCRYPT_MODE or >> DECRYPT_MODE. >> 1787: * @throws IllegalStateException if Cipher object is not in valid >> state > > "Cipher" in `{@code}`? Or make it lowercase. Ok, I will use lowercase. ------------- PR: https://git.openjdk.java.net/jdk/pull/8117