On Mon, 9 May 2022 14:00:58 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update copyright year for PBES2Core.java > > src/java.base/share/classes/com/sun/crypto/provider/PBES2Core.java line 229: > >> 227: if (key instanceof javax.crypto.interfaces.PBEKey >> pbeKey) { >> 228: salt = check(pbeKey.getSalt()); // may be null >> 229: iCount = check(pbeKey.getIterationCount()); // may >> be 0 > > It seems the return value is never 0. Oh, the comment about "may be 0" is meant toward the pbeKey.getInterationCount() call... Hmm, I will make it clearer. ------------- PR: https://git.openjdk.java.net/jdk/pull/8521