On Fri, 6 May 2022 22:26:31 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update copyright year for PBES2Core.java > > src/java.base/share/classes/com/sun/crypto/provider/PKCS12PBECipherCore.java > line 214: > >> 212: >> 213: void implInit(int opmode, Key key, AlgorithmParameterSpec params, >> 214: SecureRandom random, CipherSpi cipher) > > Why rename `cipherImpl` to `cipher`? I think `cipher` is usually a `Cipher` > object and `cipherImpl` is a good name for a `CipherSpi` object. cipher vs cipherImpl looks same to me. I can revert it back since you have a preference. ------------- PR: https://git.openjdk.java.net/jdk/pull/8521
