On Thu, 18 Aug 2022 19:13:33 GMT, Jayashree Huttanagoudar <d...@openjdk.org> 
wrote:

>> Could you please review the changes?
>> This patch is to address : 
>> https://bugs.openjdk.org/browse/JDK-8215916?jql=labels%20%3D%20starter-bug
>
> Jayashree Huttanagoudar has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Address review comments

Great. Two comments to the test:

1. Since there is only one case now, maybe you can write out the JAAS config 
file as a literal string. You can use the new multi-line string feature.
2. If the test fails, will the exception show up? I'm asking because you 
haven't restored the original `System.err` and I wonder if the exception stack 
trace is still in the byte array output stream.

-------------

PR: https://git.openjdk.org/jdk/pull/9159

Reply via email to