> Hi, > > Please review this simple code cleanup. > > The following checking for key in the makeSessionKey() method is redundant as > it the same checking has been performance before calling the method. > > > if (k == null) { > throw new InvalidKeyException("Empty key"); > } > if (!isKeySizeValid(k.length)) { > throw new InvalidKeyException("Invalid AES key length: " + > k.length + " bytes"); > } > > > No new regression test, simple cleanup. > > Thanks, > Xuelei
Xue-Lei Andrew Fan has updated the pull request incrementally with two additional commits since the last revision: - remove unused throws in comment - remove unused throws ------------- Changes: - all: https://git.openjdk.org/jdk/pull/10263/files - new: https://git.openjdk.org/jdk/pull/10263/files/fa427fd3..d915ca1b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=10263&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10263&range=00-01 Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/10263.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10263/head:pull/10263 PR: https://git.openjdk.org/jdk/pull/10263