On Tue, 25 Oct 2022 17:56:10 GMT, Xue-Lei Andrew Fan <xue...@openjdk.org> wrote:
>> Thanks Tony! > > @mcpowers Did you want to update line line 203-207 as well? It might be safe > to remove the current getID(byte[]) method. If the parameter is null, there > is an NPE (unexpected); otherwise, the new method should be safe to use. > @XueleiFan Lines 204 and 206 can't be collapsed into a single call to > getIDNullSafe because of square brackets in the output on line 204. I don't > want to change existing output in any way. Perhaps I'm not understanding your > question. I just feel that it may be not necessary to maintain both getID() and getIDNullSafe(). But no problem if you want to keep the square brackets for toString(). ------------- PR: https://git.openjdk.org/jdk/pull/10823
