On Thu, 10 Nov 2022 17:59:44 GMT, Weijun Wang <[email protected]> wrote:
>> An `EncryptedPrivateKeyInfo` object can be created with an uninitialized
>> `AlgorithmParameters`, but before you call `getEncoded` on it you need to
>> remember to initialize the params. This is unfortunate but since this is a
>> public API, I hesitate to make a change.
>>
>> Instead, this code change fixes the much more widely used internal class
>> `AlgorithmId` so that it cannot be created with an uninitialized
>> `AlgorithmParameters`. `EncryptedPrivateKeyInfo` now works with both
>> initialized and uninitialized params, and it's immutable.
>>
>> No intention to make `AlgorithmId` immutable this time. It has a child class
>> named `AlgIdDSA` which makes things complicated.
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> expected
src/java.base/share/classes/javax/crypto/EncryptedPrivateKeyInfo.java line 62:
> 60: // The "encryptionAlgorithm" field. If this object is created by
> 61: // {@link #EncryptedPrivateKeyInfo(AlgorithmParameters, byte[])}
> 62: // with an uninitialized params, it's stored here and algid is null.
A bit confused by the words "it's stored here" if it is always null for the
case where the params are uninitialized. How about: "... with an uninitialized
params, algid is null."
-------------
PR: https://git.openjdk.org/jdk/pull/11067
