On Tue, 22 Nov 2022 19:46:56 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> IssuerAlternativeNameExtension names > > src/java.base/share/classes/sun/security/x509/NameConstraintsExtension.java > line 142: > >> 140: if (permitted == null && excluded == null) { >> 141: throw new IllegalArgumentException( >> 142: "permitted and exclude cannot both be null"); > > s/exclude/excluded/ Do you want to add similar checks to the `GeneralSubtree` and `GeneralSubtrees` ctors? ------------- PR: https://git.openjdk.org/jdk/pull/11137