On Wed, 25 Jan 2023 16:12:12 GMT, Matthew Donovan <[email protected]> wrote:
>> Eirik Bjorsnos has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add whitespace between if and left parenthesis
>
> test/jdk/jdk/security/jarsigner/JarWithOneNonDisabledDigestAlg.java line 109:
>
>> 107: try {
>> 108: jarConstraints.permits("MD5", cp, false);
>> 109: throw new Exception("This test assumes that MD5 is
>> disabled");
>
> It might be clearer to say something like "This test requires MD5 to be
> disabled but it is enabled."
>
> Same for the SHA256 check below.
Thanks!. This PR was integrated yesterday, I'll keep this in mind if I do
further work in this area.
-------------
PR: https://git.openjdk.org/jdk/pull/11997
