On Wed, 12 Apr 2023 14:44:10 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> The KEM API and DHKEM impl. Note that this PR uses new methods in >> https://github.com/openjdk/jdk/pull/13250. > > src/java.base/share/classes/javax/crypto/KEMSpi.java line 39: > >> 37: * to implement a KEM algorithm. >> 38: * <p> >> 39: * A KEM algorithm may contain a family of configurations. > > Would "support" instead of "contain" be better? Good, I'll use it. > src/java.base/share/classes/javax/crypto/KEMSpi.java line 45: > >> 43: * by the KEM algorithm name, the key it uses, and an optional >> 44: * {@code AlgorithmParameterSpec} argument when creating an encapsulator >> or >> 45: * decapsulator. The result of either {@link #engineNewDecapsulator} or > > How about: "A configuration is defined by the ..." and "... argument that is > specified when ..." > > "The result of calling {@link #engineNewDecapsulator} or .." Accepted. > src/java.base/share/classes/javax/crypto/KEMSpi.java line 211: > >> 209: * The caller of this method has already validated the parameters to >> 210: * ensure that {@code pk} is not {@code null}. Therefore an >> implementation >> 211: * of this method does not to validate it. > > s/not to/not need to/ > > Also, suggest saying who the caller is, "The caller (KEM.newEncapsulator) of > this method ..." Oops. Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1164510335 PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1164512159 PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1164513349
