On Thu, 25 May 2023 21:17:40 GMT, Ben Perez <d...@openjdk.org> wrote:
> Changed `namedParams` in XECParameters and EdDSAParameters to be `private
> final`
src/jdk.crypto.ec/share/classes/sun/security/ec/XECParameters.java line 45:
> 43: static final XECParameters X448;
> 44:
> 45: private static final ParametersMap<XECParameters> namedParams = new
> ParametersMap<>();
Small code style comment - we try to keep our code lines to 80 characters or
less as it avoids scrolling for things like split screen code reviews. Suggest
putting a line break after `=` and indenting the next line four spaces, ex:
private static final ParametersMap<XECParameters> namedParams =
new ParametersMap<>();
Same comment below.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14162#discussion_r1222076066
