On Wed, 21 Jun 2023 12:04:34 GMT, Matthew Donovan <mdono...@openjdk.org> wrote:
>> There's a bit of a history with SSLSocket closures since the new handshaker >> was brought into JDK11. Some of it dealt with synchronization, others with >> properly handling full vs. half-duplex closes. You may want to look up some >> of the bug history on changes surrounding the SSLSocket closures just to >> make sure we don't undo any fixes that were previously integrated. As >> Xuelei's comment indicates, this is a delicate part of the handshaker. > > I reverted the changes to SSLEngineImpl and looked at the history of > SSLSocketImpl and TransportContext but didn't see anything that I would be > undoing with this change. Sorry for the delay on any updates here. I updated this branch and verified the tests still pass. I ran jdk_security3 tests from test/jdk/TEST.groups. Is there anything else I should do to test this change? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13742#discussion_r1262468647