Re: RFR: 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar

[Sean Mullan]

On Fri, 28 Jul 2023 15:34:47 GMT, Hai-May Chao <hc...@openjdk.org> wrote:

> JDK-8312489: Increase jdk.jar.maxSignatureFileSize default which is too low 
> for JARs such as WhiteSource/Mend unified agent jar

Changes requested by mullan (Reviewer).

src/java.base/share/classes/sun/security/util/SignatureFileVerifier.java line 
857:

> 855:                         "is used as the specified size for the " +
> 856:                         "jdk.jar.maxSignatureFileSize system property " +
> 857:                         "is out of range: " + tmp);

The wording of the message is a bit hard to understand. I suggest rewording 
slightly as: 

                debug.println("The default signature file size of 16000000 
bytes " +
                        "will be used as the specified size for the " +
                        "jdk.jar.maxSignatureFileSize system property " +
                        "since the value is out of range: " + tmp);

-------------

PR Review: https://git.openjdk.org/jdk/pull/15072#pullrequestreview-1552842236
PR Review Comment: https://git.openjdk.org/jdk/pull/15072#discussion_r1278018761