On Tue, 19 Sep 2023 17:09:56 GMT, Ben Perez <[email protected]> wrote:
>> Replaced "jks" with "pkcs12" in both the spec and fallback for
>> `KeyStore.getDefaultType()`
>
> Ben Perez has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Added test to check that when keystore.type is null it defaults to pkcs12
Marked as reviewed by hchao (Committer).
test/jdk/java/security/KeyStore/PKCS12/CheckNullDefault.java line 42:
> 40: private void runTest(String[] args) {
> 41: if (!KeyStore.getDefaultType().
> 42: equalsIgnoreCase(DEFAULT_KEY_STORE_TYPE)) {
nits: indent 8 spaces for line continuation (on #42 and #45)
-------------
PR Review: https://git.openjdk.org/jdk/pull/15625#pullrequestreview-1634292564
PR Review Comment: https://git.openjdk.org/jdk/pull/15625#discussion_r1330766092
