On Wed, 8 Nov 2023 05:13:04 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Erik Gahlin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename field from tracing to jfrTracing
>
> src/java.base/share/classes/jdk/internal/event/ThrowableTracer.java line 62:
>
>> 60: if (ExceptionThrownEvent.enabled()) {
>> 61: long timestamp = ExceptionThrownEvent.timestamp();
>> 62: ExceptionThrownEvent.commit(timestamp, message, clazz);
>
> Just a drive-by observation, but now you get the timestamp from the event it
> seems strange to pull it out and then pass it back to commit, instead of
> having a version of commit that automatically uses the internal timestamp.
I agree, and I have looked into it, but I think it's better to do that
refactorization separately as it will impact other events.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16493#discussion_r1386016878
