On Tue, 19 Dec 2023 12:21:05 GMT, Raffaello Giulietti <[email protected]>
wrote:
>> Adds serialization misdeclaration events to JFR.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Better name for a label, corrected name of removed field.
test/jdk/jdk/jfr/event/io/TestSerializationMisdeclarationEvent.java line 112:
> 110: @MethodSource
> 111: public void testGoodClass(Class<?> cls) {
> 112: assertEquals(0, getEventsFor(cls).size());
Can this and other assertions in this test be updated to include the class name
which failed? You can still use `assertEquals(...)`, it takes an optional
message as a third parameter which you could use to include the failing class
name. It becomes a bit more easier to debug (unexpected) failures when the
assertion includes these additional details.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17129#discussion_r1431563775
