Re: RFR: 8275338: Add JFR events for notable serialization situations [v9]

[Erik Gahlin]

On Thu, 21 Dec 2023 09:36:06 GMT, Raffaello Giulietti <rgiulie...@openjdk.org> 
wrote:

>> Adds serialization misdeclaration events to JFR.
>
> Raffaello Giulietti has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Removed @module from test.

src/jdk.jfr/share/classes/jdk/jfr/events/SerializationMisdeclarationEvent.java 
line 37:

> 35: 
> 36: @Name(Type.EVENT_NAME_PREFIX + "SerializationMisdeclaration")
> 37: @Label("Serialization Deserialization")

The label of the event seems incorrect, shouldn't it be "Serialization 
Misdeclaration"?

src/jdk.jfr/share/classes/jdk/jfr/events/SerializationMisdeclarationEvent.java 
line 47:

> 45: public final class SerializationMisdeclarationEvent extends 
> AbstractJDKEvent {
> 46: 
> 47:     @Label("MisdeclaredClass")

Should be "Misdeclared Class"

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17129#discussion_r1433814736
PR Review Comment: https://git.openjdk.org/jdk/pull/17129#discussion_r1433813701