On Fri, 9 Feb 2024 11:38:07 GMT, Darragh Clarke <dcla...@openjdk.org> wrote:
> Currently these tests ignore vm flags, In most cases I've updated them to use > `ProcessTools.createTestJavaProcessBuilder` this usually required some > cleanup also. > > `test/jdk/java/net/ServerSocket/AcceptCauseFileDescriptorLeak.java` and > `test/jdk/java/net/URLConnection/6212146/TestDriver.java` have been set to > use `@require vm.flagless` because they both use `sh` commands. > > I've ran these changes against tiers 1-3 and everything seems stable These changes look good to me. The `TLSWontNegotiateDisabledCipherAlgos.java` would need a copyright year update. ------------- Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17787#pullrequestreview-1882605013
