On Thu, 22 Feb 2024 22:41:10 GMT, Anthony Scarpino <ascarp...@openjdk.org> 
wrote:

>> Hi,
>> 
>> I need a code review of what is really a text change.  This changes the 
>> alert type returned during some TLS CertificateMessage failures to what is 
>> recommended in [RFC 8446](https://tools.ietf.org/html/rfc8446).  An 
>> additional change was to add the alert description to the thrown exception.  
>> This makes it easier for the user to know the alert type and makes testing 
>> easier.  Two of the three changes are tested as the final one is too hard to 
>> test.  A few tests needed change as they did string comparing on exception 
>> messages.
>> 
>> Tony
>
> Anthony Scarpino has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   review comments

Marked as reviewed by ssahoo (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17717#pullrequestreview-1897362301

Reply via email to