On Tue, 25 Jun 2024 09:38:04 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> Anthony Scarpino has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - remove frag issue
>> - Comments, remove thread, set NST default to 1, allow 0
>> - comment cleanup
>
> src/java.base/share/classes/sun/security/util/Cache.java line 716:
>
>> 714: }
>> 715: if (entry.isValid(time)) {
>> 716: // SoftReference get() returns the same as
>> entry.getValue()
>
> this doesn't look right
I checked it through debugging. I was a bit surprised myself that it didn't
return the `QueueCacheEntry`.get(). I can switch it the below if that's
agreeable.
if (entry.isValid(time)) {
if (entry instanceof SoftCacheEntry<K,V> sce) {
return sce.get();
}
return entry.getValue();
}
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19465#discussion_r1657583824
