On Wed, 7 Aug 2024 17:47:42 GMT, Weijun Wang <[email protected]> wrote:
>> Francisco Ferrari Bihurriet has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Throw an IllegalArgumentException exception if
>> Security.setProperty("include", ...) is invoked.
>>
>> Co-authored-by: Martin Balao <[email protected]>
>> Co-authored-by: Francisco Ferrari Bihurriet <[email protected]>
>
> src/java.base/share/classes/java/security/Security.java line 118:
>
>> 116: }
>> 117:
>> 118: private static void loadMaster() {
>
> Maybe you can rename to `loadMain`. There have been some voices against the
> usage of the "master" word.
We had internally discussed about this. In order to avoid confusion, we decided
to align with the terminology already present in `java.security`.
Given that such a change would require a bigger searching effort (e.g. what
terminology is used in user guides and/or other public APIs documentation?), we
think this should be addressed in its own enhancement.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16483#discussion_r1707815922
