On Wed, 7 Aug 2024 20:10:39 GMT, Francisco Ferrari Bihurriet
<[email protected]> wrote:
>> src/java.base/share/classes/java/security/Security.java line 118:
>>
>>> 116: }
>>> 117:
>>> 118: private static void loadMaster() {
>>
>> Maybe you can rename to `loadMain`. There have been some voices against the
>> usage of the "master" word.
>
> We had internally discussed about this. In order to avoid confusion, we
> decided to align with the terminology already present in `java.security`.
>
> Given that such a change would require a bigger searching effort (e.g. what
> terminology is used in user guides and/or other public APIs documentation?),
> we think this should be addressed in its own enhancement.
Oh, sorry I didn't realize the `java.security` file also uses it. I remember
long long ago we've gone through the JDK codebase on this naming issue. I don't
remember if this one was not considered an issue or had been exempted. Anyway,
yes we don't need to touch it this time.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16483#discussion_r1707937609
