On Tue, 13 Aug 2024 18:08:29 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Will discuss "offline" with the other `KDFParameters` & DPS discussion. > > This will imp[act the API, e.g. whether KDFSpi needs an > `engineGetKDFParameters()` method. BTW, I find the name > "KDFParameters" very confusing as there is a parameter spec in the > `deriveKey()` method named "kdfParameterSpec". The JCA convention uses > `AlgorithmParameters` and `AlgorithmParameterSpec` interchangeably, the > former is an opaque representation vs the later is a transparent form which > algorithm specific values are readily retrievable. > Maybe name the parameters more specifically based on their purpose? Say, > "configParams" for the ones used in `getInstance(...)`, "deriveParams" for > the one in `deriveKey()`. @valeriepeng: This was addressed in https://github.com/openjdk/jdk/pull/20301/commits/59a3f02015f7fc3ad81ca29b90d83b1c9bd70fc5. You may be looking at older source. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1715841842
