On Fri, 16 Aug 2024 21:10:40 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line
>> 362:
>>
>>> 360: *
>>> 361: * @param prk
>>> 362: * the pseudorandom key; may be {@code null}
>>
>> Instead of stating "prk may be {@null}", how about narrow it down/clarify to
>> "in the case of ExtractThenExpand, prk may be {@null} since the output of
>> extract phase is used"
>
> Numerous comments elsewhere in the code illustrate what's happening. Is your
> concern for readers of the javadoc? This is probably a valid suggestion.
Addressed in
https://github.com/openjdk/jdk/pull/20301/commits/48395b86ba8e1cda663ae326e06ae2556f4b905a.
Please indicate if this is resolved.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1722375773
