On Wed, 14 Aug 2024 01:57:40 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> addressed several review comments, namely: - renaming the getParameters >> method - renaming the AlgorithmParameterSpec object - address some javadoc >> exception messages - add some information to KDF class private constructor >> javadocs - other general cleanup > > src/java.base/share/classes/javax/crypto/KDF.java line 585: > >> 583: throw e; >> 584: } >> 585: } > > As discussed separately, if we enhance the logic of finding the > `firstService` with the instantiation and instaneof KDFSpi check (on line > 564-567), then we don't need to repeat the code here. We can just simply > assign it to `spi`, set `serviceIterator` to `null` and be done with it. Addressed in https://github.com/openjdk/jdk/pull/20301/commits/c9c3bc6cb16157a13e898e807cbf0cf8a30fb045. Please indicate if this is resolved. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1723910675
