On Sat, 24 Aug 2024 12:02:49 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> In preparation for the new PQC algorithms implementations, internal XOF >> (eXtendable Output Function) methods are added to the SHAKE128 and SHAKE256 >> implementations. > > src/java.base/share/classes/sun/security/provider/SHA3.java line 123: > >> 121: */ >> 122: void implDigest(byte[] out, int ofs) { >> 123: byte[] byteState = new byte[8]; > > `byteState` can be moved to line 150. If I do that, the performance drops a little. So I rather keep it here. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20631#discussion_r1731261658