On Fri, 4 Apr 2025 13:51:33 GMT, Sean Mullan <[email protected]> wrote:
>> Koushik Muthukrishnan Thirupattur has updated the pull request incrementally
>> with one additional commit since the last revision:
>>
>> 8349890:Option -Djava.security.debug=x509,ava breaks special chars
>
> test/jdk/sun/security/x509/X500Name/PrintX500NameInDebugModeWithAvaOption.java
> line 39:
>
>> 37: public static void main(String[] args) throws Exception {
>> 38:
>> 39: X500Name name = new X500Name("cn=john doe + l=ca\\+lifornia + l
>> =sf, O=Ñ");
>
> Use `X500Principal` objects for testing instead of `X500Name`.
> `X500Principal` is a public/standard API, so it is better to ensure that the
> issue is fixed via standard APIs. Then you also don't need the `@modules`
> line.
>
> Also change name of test to `PrintX500PrincipalInDebugModeWithAvaOption`.
Changed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24360#discussion_r2029214843
