On Mon, 12 May 2025 20:36:40 GMT, Sean Mullan <[email protected]> wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comments on the 11th
>
> src/java.base/share/classes/java/security/PEMRecord.java line 129:
>
>> 127: *
>> 128: * @param type the type identifier in the PEM header and footer, or
>> {@code null} if there is no PEM data.
>> 129: * @param pem the data between the PEM header and footer.
>
> I thought the bytes were the DER encoded data. Wouldn't that be useful, if
> you were trying to PEM encode a certificate with extra leading data, for
> example?
I tried to have something similar, but because of `record` it didn't flow
right. I would prefer a more clear way to say your providing DER vs PEM..
something like `fromDER()`. But the more options that were allowed it became
less it's intent.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2089846646
