On Thu, 5 Jun 2025 08:14:15 GMT, Fernando Guallini <[email protected]>
wrote:
>> The tests included in this PR add code coverage mainly to the following
>> classes introduced/updated by JEP 470 (PEM): PEMDecoder, PEMEncoder, Pem,
>> EncryptedPrivateKeyInfo and the Key factories. In addition, more tests are
>> included for RSAPSS, multithreading, _jdk.epkcs8.defaultAlgorithm_ property
>> and some negative testing
>
> Fernando Guallini has updated the pull request with a new target base due to
> a merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains nine additional
> commits since the last revision:
>
> - comment
> - Merge branch 'master' into 8358171
> - add invalid PEM content test
> - Merge branch 'master' into 8358171
> - add logging line
> - lines comments
> - add final break and test comment
> - multi thread and defaut algo tests
> - more test coverage for PEM
test/jdk/java/security/PEM/PEMDecoderTest.java line 536:
> 534: case "EC" -> "SHA256withECDSA";
> 535: case "EdDSA" -> "EdDSA";
> 536: case "RSASSA-PSS" -> {
Suggestion:
case "RSASSA-PSS" -> {
test/jdk/java/security/PEM/PEMMultiThreadTest.java line 47:
> 45: public static void main(String[] args) throws Exception {
> 46: PEMEncoder encoder = PEMEncoder.of();
> 47: try(ExecutorService ex =
> Executors.newFixedThreadPool(THREAD_COUNT)) {
Suggestion:
try (ExecutorService ex = Executors.newFixedThreadPool(THREAD_COUNT)) {
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25588#discussion_r2128316054
PR Review Comment: https://git.openjdk.org/jdk/pull/25588#discussion_r2128316488
