On Thu, 17 Jul 2025 02:47:23 GMT, Hai-May Chao <hc...@openjdk.org> wrote:
>> Hi >> >> I need a review for a client-server threading change that will hopefully >> address intermittent failures. This change is similar to >> [JDK-8348309](https://bugs.openjdk.org/browse/JDK-8348309). The functional >> testing is unchanged. >> >> thanks >> >> Tony > > test/jdk/sun/security/ssl/SSLSessionImpl/ResumeChecksClient.java line 92: > >> 90: // fail if session is not resumed >> 91: checkResumedSession(firstSession, secondSession); >> 92: System.out.println("secondSession used resumption: PASS"); > > Would you consider to catch the exception from checkRsumedSession() if for > some reason resumption fails unexpectedly and log that the test failed due to > unexpected session mismatch? To clarify, are you asking for a more helpful error message, like "session was not resumed"? Rather than just the error from `checkResumedSession()`? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26206#discussion_r2214200471
