On Mon, 21 Jul 2025 11:46:36 GMT, Matthew Donovan <mdono...@openjdk.org> wrote:
>> Mikhail Yankelevich has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changing alert to JOptionPane
>
> test/jdk/sun/security/krb5/config/native/TestDynamicStore.java line 63:
>
>> 61: // Show a popup to remind to run this test as sudo user
>> 62: // this will only trigger if sudo (root) user is not detected
>> 63: if ("root".equals(System.getProperty("user.name"))) {
>
> I think you're missing a `!` here.
Yes, thank you for noticing! Will be changed in the next commit
> test/jdk/sun/security/krb5/config/native/TestDynamicStore.java line 66:
>
>> 64:
>> 65: JOptionPane.showMessageDialog(null, """
>> 66: This test MUST be run with SUDO user.\s
>
> Instead of saying "sudo user", maybe just say "this test must be run as root"
> then they can run it with sudo or su or whatever they prefer.
I agree, will change in the next commit
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26293#discussion_r2218968183
PR Review Comment: https://git.openjdk.org/jdk/pull/26293#discussion_r2218968719
