On Fri, 22 Aug 2025 11:59:24 GMT, Matthew Donovan <[email protected]> wrote:
>> This PR updates `ArtifactResolver.fetchOne()` to throw an IOException
>> instead of SkippedException. This allows tests to determine of a missing
>> "artifact" should be treated as a failed or skipped
>> test.`OpensslArtifactFetcher` is also updated to only throw SkippedException
>> if OpenSSL is not available on the test platform.
>
> Matthew Donovan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> updated PKCS11Test to catch IOException and throw Skipped
test/lib/jdk/test/lib/security/OpensslArtifactFetcher.java line 52:
> 50: *
> 51: * @return openssl binary path of the current version
> 52: * @throws SkippedException if OpenSSL is not available on the target
> platform
Since `SkippedException` is now thrown in all cases, the JavaDoc `@throws`
clauses should be merged.
Suggestion:
* @throws SkippedException if a valid version of OpenSSL cannot be found
* or if OpenSSL is not available on the target platform
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26868#discussion_r2294111409
