On Wed, 17 Sep 2025 14:52:36 GMT, Mark Powers <[email protected]> wrote:

>> src/java.base/share/classes/com/sun/crypto/provider/SunJCE.java line 544:
>> 
>>> 542:                 
>>> "com.sun.crypto.provider.PBES2Parameters$HmacSHA512_256AndAES_256");
>>> 543: 
>>> 544:         psA("AlgorithmParameters", "PBMAC1",
>> 
>> Why do we need to expose this as a standard `AlgorithmParameters` algorithm 
>> as part of this change? Maybe this would be useful later, but I don't think 
>> it is needed as this enhancement is just for internal use in PKCS12 KeyStore.
>
> Not yet. I'm looking at Sean's comments today.

And this duplicates `MacData.getEncoded()`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24429#discussion_r2355821287

Reply via email to